v1.10.10: fixing stream response getting stuck when writing >32k on a...

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

v1.10.10: fixing stream response getting stuck when writing >32k on a...

Jacob Perkins
Howdy!

We’re starting to see this issue crop up with our customers. We tried patching the commit, but it doesn’t patch cleanly against the latest 2.4.x.

Is the recommended option here to build against h2 master instead of what’s packaged with 2.4? 

Jacob Perkins
Product Owner
cPanel Inc.

Office:  713-529-0800 x 4046
Cell:  713-560-8655


smime.p7s (4K) Download Attachment
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: v1.10.10: fixing stream response getting stuck when writing >32k on a...

Stefan Eissing
Hi Jacob,

you can use the github release or I can make a patch for 2.4.27 tomorrow. Just say what you prefer. 

-Stefan

Am 09.08.2017 um 18:39 schrieb Jacob Perkins <[hidden email]>:

Howdy!

We’re starting to see this issue crop up with our customers. We tried patching the commit, but it doesn’t patch cleanly against the latest 2.4.x.

Is the recommended option here to build against h2 master instead of what’s packaged with 2.4? 

Jacob Perkins
Product Owner
cPanel Inc.

Office:  713-529-0800 x 4046
Cell:  713-560-8655

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: v1.10.10: fixing stream response getting stuck when writing >32k on a...

Jacob Perkins
Hi Stefan,

A patch for 2.4.27 would be great. 

Your assistance is greatly appreciated. 
Jacob Perkins
Product Owner
cPanel Inc.

Office:  713-529-0800 x 4046
Cell:  713-560-8655

On Aug 9, 2017, at 12:33 PM, Stefan Eissing <[hidden email]> wrote:

Hi Jacob,

you can use the github release or I can make a patch for 2.4.27 tomorrow. Just say what you prefer. 

-Stefan

Am 09.08.2017 um 18:39 schrieb Jacob Perkins <[hidden email]>:

Howdy!

We’re starting to see this issue crop up with our customers. We tried patching the commit, but it doesn’t patch cleanly against the latest 2.4.x.

Is the recommended option here to build against h2 master instead of what’s packaged with 2.4? 

Jacob Perkins
Product Owner
cPanel Inc.

Office:  713-529-0800 x 4046
Cell:  713-560-8655



smime.p7s (4K) Download Attachment
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: v1.10.10: fixing stream response getting stuck when writing >32k on a...

Stefan Eissing

> Am 09.08.2017 um 20:32 schrieb Jacob Perkins <[hidden email]>:
>
> Hi Stefan,
>
> A patch for 2.4.27 would be great.
>
> Your assistance is greatly appreciated.

Gladly. Patch available at: https://github.com/icing/mod_h2/blob/master/patches/mod_h2-v1.10.10-apache-2.4.x.diff

Cheers,

Stefan

> —
> Jacob Perkins
> Product Owner
> cPanel Inc.
>
> [hidden email]
> Office:  713-529-0800 x 4046
> Cell:  713-560-8655
>
>> On Aug 9, 2017, at 12:33 PM, Stefan Eissing <[hidden email]> wrote:
>>
>> Hi Jacob,
>>
>> you can use the github release or I can make a patch for 2.4.27 tomorrow. Just say what you prefer.
>>
>> -Stefan
>>
>> Am 09.08.2017 um 18:39 schrieb Jacob Perkins <[hidden email]>:
>>
>>> Howdy!
>>>
>>> We’re starting to see this issue crop up with our customers. We tried patching the commit, but it doesn’t patch cleanly against the latest 2.4.x.
>>>
>>> Is the recommended option here to build against h2 master instead of what’s packaged with 2.4?
>>>
>>> —
>>> Jacob Perkins
>>> Product Owner
>>> cPanel Inc.
>>>
>>> [hidden email]
>>> Office:  713-529-0800 x 4046
>>> Cell:  713-560-8655
>>>
>

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: v1.10.10: fixing stream response getting stuck when writing >32k on a...

Jacob Perkins
Good morning,

This patched cleanly and we’re in the process of testing it now. Many thanks Stefan! I owe you a beer or two at the next ApacheCon.

Jacob Perkins
Product Owner
cPanel Inc.

Office:  713-529-0800 x 4046
Cell:  713-560-8655

On Aug 10, 2017, at 4:37 AM, Stefan Eissing <[hidden email]> wrote:


Am 09.08.2017 um 20:32 schrieb Jacob Perkins <[hidden email]>:

Hi Stefan,

A patch for 2.4.27 would be great.

Your assistance is greatly appreciated.

Gladly. Patch available at: https://github.com/icing/mod_h2/blob/master/patches/mod_h2-v1.10.10-apache-2.4.x.diff

Cheers,

Stefan


Jacob Perkins
Product Owner
cPanel Inc.

[hidden email]
Office:  713-529-0800 x 4046
Cell:  713-560-8655

On Aug 9, 2017, at 12:33 PM, Stefan Eissing <[hidden email]> wrote:

Hi Jacob,

you can use the github release or I can make a patch for 2.4.27 tomorrow. Just say what you prefer.

-Stefan

Am 09.08.2017 um 18:39 schrieb Jacob Perkins <[hidden email]>:

Howdy!

We’re starting to see this issue crop up with our customers. We tried patching the commit, but it doesn’t patch cleanly against the latest 2.4.x.

Is the recommended option here to build against h2 master instead of what’s packaged with 2.4?


Jacob Perkins
Product Owner
cPanel Inc.

[hidden email]
Office:  713-529-0800 x 4046
Cell:  713-560-8655





smime.p7s (4K) Download Attachment
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: v1.10.10: fixing stream response getting stuck when writing >32k on a...

William A Rowe Jr
In reply to this post by Stefan Eissing
On Thu, Aug 10, 2017 at 4:37 AM, Stefan Eissing
<[hidden email]> wrote:

>
>> Am 09.08.2017 um 20:32 schrieb Jacob Perkins <[hidden email]>:
>>
>> Hi Stefan,
>>
>> A patch for 2.4.27 would be great.
>>
>> Your assistance is greatly appreciated.
>
> Gladly. Patch available at: https://github.com/icing/mod_h2/blob/master/patches/mod_h2-v1.10.10-apache-2.4.x.diff

This seems pretty significant for a now GA module? Two thoughts...

Duplicate the patch (against httpd dist) into
www.a.o/dist/httpd/patches/apply_to_2.4.27/ ?

Step up plans to T&R 2.4.28 to supersede the problematic code?
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: v1.10.10: fixing stream response getting stuck when writing >32k on a...

Stefan Eissing

> Am 10.08.2017 um 16:18 schrieb William A Rowe Jr <[hidden email]>:
>
> On Thu, Aug 10, 2017 at 4:37 AM, Stefan Eissing
> <[hidden email]> wrote:
>>
>>> Am 09.08.2017 um 20:32 schrieb Jacob Perkins <[hidden email]>:
>>>
>>> Hi Stefan,
>>>
>>> A patch for 2.4.27 would be great.
>>>
>>> Your assistance is greatly appreciated.
>>
>> Gladly. Patch available at: https://github.com/icing/mod_h2/blob/master/patches/mod_h2-v1.10.10-apache-2.4.x.diff
>
> This seems pretty significant for a now GA module? Two thoughts...
>
> Duplicate the patch (against httpd dist) into
> www.a.o/dist/httpd/patches/apply_to_2.4.27/ ?

Where is that exactly and what do I need to do?

> Step up plans to T&R 2.4.28 to supersede the problematic code?

+1

Several things have been added in STATUS for backport.
Loading...