Re: svn commit: r1879253 - /httpd/httpd/trunk/server/util_script.c

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: svn commit: r1879253 - /httpd/httpd/trunk/server/util_script.c

Ruediger Pluem


On 6/27/20 11:11 AM, [hidden email] wrote:

> Author: elukey
> Date: Sat Jun 27 09:11:32 2020
> New Revision: 1879253
>
> URL: http://svn.apache.org/viewvc?rev=1879253&view=rev
> Log:
> server/util_script.c: tune logging Last-Modified header
>
> Follow up after Joe's feedback in STATUS:
>   - If APR_DATE_BAD is returned for Last-Modified, log it at INFO level
>     (as opposed to trace).
>   - Remove unnecessary guard for APLOGrtrace1(r).


As this is now a APLOG_INFO, can you please add an APLOGNO?
For further details please have a look at docs/log-message-tags/README

Regards

RĂ¼diger

Reply | Threaded
Open this post in threaded view
|

Re: svn commit: r1879253 - /httpd/httpd/trunk/server/util_script.c

Luca Toscano
On Mon, Jun 29, 2020 at 9:12 AM Ruediger Pluem <[hidden email]> wrote:

>
>
>
> On 6/27/20 11:11 AM, [hidden email] wrote:
> > Author: elukey
> > Date: Sat Jun 27 09:11:32 2020
> > New Revision: 1879253
> >
> > URL: http://svn.apache.org/viewvc?rev=1879253&view=rev
> > Log:
> > server/util_script.c: tune logging Last-Modified header
> >
> > Follow up after Joe's feedback in STATUS:
> >   - If APR_DATE_BAD is returned for Last-Modified, log it at INFO level
> >     (as opposed to trace).
> >   - Remove unnecessary guard for APLOGrtrace1(r).
>
>
> As this is now a APLOG_INFO, can you please add an APLOGNO?
> For further details please have a look at docs/log-message-tags/README

Thanks for the pointer, hopefully fixed with r1879348.

Luca