Re: svn commit: r1862270 - in /httpd/httpd/trunk/modules/dav: fs/dbm.c fs/repos.c main/mod_dav.c main/props.c main/std_liveprop.c main/util.c

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: svn commit: r1862270 - in /httpd/httpd/trunk/modules/dav: fs/dbm.c fs/repos.c main/mod_dav.c main/props.c main/std_liveprop.c main/util.c

Graham Leggett
On 28 Jun 2019, at 10:50, [hidden email] wrote:

* Replace apr_psprintf with apr_pstrcat where the format strings only
 contain %s to improve efficiency. Leave out error messages as they
 are not on a crtical code path and error message become less readable
 when taking out the format specifiers.

I’ve proposed this for backport, as it blocks other dav changes. Would it be possible to take a look?

Regards,
Graham

Reply | Threaded
Open this post in threaded view
|

Re: svn commit: r1862270 - in /httpd/httpd/trunk/modules/dav: fs/dbm.c fs/repos.c main/mod_dav.c main/props.c main/std_liveprop.c main/util.c

Ruediger Pluem


On 6/29/20 5:52 PM, Graham Leggett wrote:
> On 28 Jun 2019, at 10:50, [hidden email] <mailto:[hidden email]> wrote:
>
>> * Replace apr_psprintf with apr_pstrcat where the format strings only
>>  contain %s to improve efficiency. Leave out error messages as they
>>  are not on a crtical code path and error message become less readable
>>  when taking out the format specifiers.
>
> I’ve proposed this for backport, as it blocks other dav changes. Would it be possible to take a look?

Voted.

Regards

Rüdiger