Re: svn commit: r1795906 - in /httpd/httpd/branches/2.4.x: ./ CHANGES STATUS server/request.c

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view

Re: svn commit: r1795906 - in /httpd/httpd/branches/2.4.x: ./ CHANGES STATUS server/request.c

Luca Toscano

You are completely right, I missed the documentation update. I added the "Not a scripting language" paragraph while working on the nested <If> change, double shame :)

Will do it later on today, thanks for the reminder!


2017-05-25 8:32 GMT+02:00 Christophe JAILLET <[hidden email]>:

Looks like doc should be updated accordingly. Especially, the paragraph stating that:
"For example, the current implementation does not contemplate the possibility of having a <If> section inside another one (the inner <If> will be ignored). "

A compatibility note should be also added to tell that the behavior has changed in 2.4.26.

Not sure how to rephrase the "Not a scripting language" paragraph, though. Delete it completely?


Le 23/05/2017 à 14:48, [hidden email] a écrit :
Author: jim
Date: Tue May 23 12:48:27 2017
New Revision: 1795906

Merge r1792589 from trunk:

Evaluate nested If/ElseIf/Else config sections

It has been reported multiple times that nested
If/ElseIf/Else sections are not evaluated but
silently ignored.

This patch adds a simple recursion to the ap_if_walk
logic in order to allow arbitrary nested configs.
The overhead seems negligible compared to the actual
version of the ap_if_walk, but more expert feedback
is surely needed since this code gets called for every
HTTP request.

Tests are going to be added to t/apache/if_sections.t

Submitted by: elukey
Reviewed by: elukey, jim, yalvic

     httpd/httpd/branches/2.4.x/   (props changed)

Modified: httpd/httpd/branches/2.4.x/CHANGES
--- httpd/httpd/branches/2.4.x/CHANGES [utf-8] (original)
+++ httpd/httpd/branches/2.4.x/CHANGES [utf-8] Tue May 23 12:48:27 2017
@@ -2,6 +2,9 @@
    Changes with Apache 2.4.26
  +  *) Evaluate nested If/ElseIf/Else configuration blocks.
+     [Luca Toscano, Jacob Champion]
    *) mod_substitute: Fix spurious AH01328 (Line too long) errors on EBCDIC
       systems.  [Eric Covener]

To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]