Patches related to HTML output by Apache httpd itself

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

Patches related to HTML output by Apache httpd itself

Andras Farkas
Evening!

I noticed that most of the time, when Apache httpd itself generates
HTML output (like for 404 pages and autoindex pages) it uses ancient
HTML 2.0 and HTML 3.2 doctypes.
These 11 attached diffs update those.  The most important of the diffs
is httpdh.diff
I compiled and tested these diffs, and everything I tested works fine!
 Browsers now render those pages in standards mode rather than quirks
mode.
While I made these patches for httpd 2.4.37 these patches would likely
also be useful for trunk.
This could be the first step in making sure all the HTML output is more valid.

Thank you for reading this email.

mod_davh.diff (926 bytes) Download Attachment
mod_autoindexc.diff (710 bytes) Download Attachment
httpdh.diff (1022 bytes) Download Attachment
http_protocolc.diff (628 bytes) Download Attachment
indexhtml.diff (988 bytes) Download Attachment
mod_proxy_balancerc.diff (688 bytes) Download Attachment
mod_proxy_ftpc.diff (688 bytes) Download Attachment
mod_imagemapc.diff (684 bytes) Download Attachment
mod_example_hooksc.diff (742 bytes) Download Attachment
util_ldapc.diff (656 bytes) Download Attachment
mod_statusc.diff (602 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Patches related to HTML output by Apache httpd itself

Andras Farkas
Ping.
On Mon, Nov 26, 2018 at 4:08 AM Andras Farkas <[hidden email]> wrote:

>
> Evening!
>
> I noticed that most of the time, when Apache httpd itself generates
> HTML output (like for 404 pages and autoindex pages) it uses ancient
> HTML 2.0 and HTML 3.2 doctypes.
> These 11 attached diffs update those.  The most important of the diffs
> is httpdh.diff
> I compiled and tested these diffs, and everything I tested works fine!
>  Browsers now render those pages in standards mode rather than quirks
> mode.
> While I made these patches for httpd 2.4.37 these patches would likely
> also be useful for trunk.
> This could be the first step in making sure all the HTML output is more valid.
>
> Thank you for reading this email.
Reply | Threaded
Open this post in threaded view
|

Re: Patches related to HTML output by Apache httpd itself

Nick Kew-3

> On 6 Dec 2018, at 11:34, Andras Farkas <[hidden email]> wrote:
>
> Ping.
> On Mon, Nov 26, 2018 at 4:08 AM Andras Farkas <[hidden email]> wrote:
>>
>> Evening!
>>
>> I noticed that most of the time, when Apache httpd itself generates
>> HTML output (like for 404 pages and autoindex pages) it uses ancient
>> HTML 2.0 and HTML 3.2 doctypes.
>> These 11 attached diffs update those.  The most important of the diffs
>> is httpdh.diff

These would be better submitted to bugzilla at issues.apache.org, where someone
might adopt them.

However, I should point out that there's nothing wrong with the existing stuff.
If I were to refactor the error messages, I'd be looking to take all remaining
actual HTML out of the server itself, and into documents (or templates) under
the control of the sysop.

(And I wouldn't touch your indexhtml with a bargepole)!

--
Nick Kew
Reply | Threaded
Open this post in threaded view
|

Re: Patches related to HTML output by Apache httpd itself

Andras Farkas
On Thu, Dec 6, 2018 at 7:04 AM Nick Kew <[hidden email]> wrote:
> These would be better submitted to bugzilla at issues.apache.org, where someone
> might adopt them.
Ah, thank you for this info!  I'll do that soon.
> However, I should point out that there's nothing wrong with the existing stuff.
> If I were to refactor the error messages, I'd be looking to take all remaining
> actual HTML out of the server itself, and into documents (or templates) under
> the control of the sysop.
Invalid HTML is inherently wrong, and there's also no need to tell
browsers to render in quirks mode by intentionally using an old
doctype.
Good idea though, to move the HTML into their own documents.
> (And I wouldn't touch your indexhtml with a bargepole)!
I'll make a new diff with less drastic changes.