[Bug 64755] New: Improve the log message for dav_fs_copymove_file

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

[Bug 64755] New: Improve the log message for dav_fs_copymove_file

Bugzilla from bugzilla@apache.org
https://bz.apache.org/bugzilla/show_bug.cgi?id=64755

            Bug ID: 64755
           Summary: Improve the log message for dav_fs_copymove_file
           Product: Apache httpd-2
           Version: 2.5-HEAD
          Hardware: PC
                OS: Mac OS X 10.1
            Status: NEW
          Severity: normal
          Priority: P2
         Component: mod_dav_fs
          Assignee: [hidden email]
          Reporter: [hidden email]
  Target Milestone: ---

Created attachment 37457
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=37457&action=edit
A patch to improve the error message for dav_fs_copymove_file

The previous log message only says "Could not open file for reading/writing",
but the file paths are different in reading or writing. I added the file name
into the log message, so that people can see the which file path may have
read/write permission problems.


Please find the attached patch. Any thoughts are appreciated!

------
* modules/dav/fs/repo.c: Add filepath in the log messages of
dav_fs_copymove_file to differentiate src and dst filepath
location

--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[Bug 64755] Improve the log message for dav_fs_copymove_file

Bugzilla from bugzilla@apache.org
https://bz.apache.org/bugzilla/show_bug.cgi?id=64755

--- Comment #1 from Bingyu Shen <[hidden email]> ---
Also reported on GitHub.

https://github.com/apache/httpd/pull/143

--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[Bug 64755] Improve the log message for dav_fs_copymove_file

Bugzilla from bugzilla@apache.org
In reply to this post by Bugzilla from bugzilla@apache.org
https://bz.apache.org/bugzilla/show_bug.cgi?id=64755

--- Comment #2 from Christophe JAILLET <[hidden email]> ---
Hi,

a space is missing between "...file" and "for...".
No need to update the proposal, I guess that it can be fixed when merged.

--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[Bug 64755] Improve the log message for dav_fs_copymove_file

Bugzilla from bugzilla@apache.org
In reply to this post by Bugzilla from bugzilla@apache.org
https://bz.apache.org/bugzilla/show_bug.cgi?id=64755

Bingyu Shen <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37457|0                           |1
        is obsolete|                            |

--- Comment #3 from Bingyu Shen <[hidden email]> ---
Created attachment 37458
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=37458&action=edit
New patch, fixed the spacing issue

--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[Bug 64755] Improve the log message for dav_fs_copymove_file

Bugzilla from bugzilla@apache.org
In reply to this post by Bugzilla from bugzilla@apache.org
https://bz.apache.org/bugzilla/show_bug.cgi?id=64755

--- Comment #4 from Bingyu Shen <[hidden email]> ---
(In reply to Christophe JAILLET from comment #2)
> Hi,
>
> a space is missing between "...file" and "for...".
> No need to update the proposal, I guess that it can be fixed when merged.

Thanks, fixed that in the new patch.

Regards,
Bingyu

--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[Bug 64755] [has patch] Improve the log message for dav_fs_copymove_file

Bugzilla from bugzilla@apache.org
In reply to this post by Bugzilla from bugzilla@apache.org
https://bz.apache.org/bugzilla/show_bug.cgi?id=64755

Bingyu Shen <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Improve the log message for |[has patch] Improve the log
                   |dav_fs_copymove_file        |message for
                   |                            |dav_fs_copymove_file

--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[Bug 64755] [has patch] Improve the log message for dav_fs_copymove_file

Bugzilla from bugzilla@apache.org
In reply to this post by Bugzilla from bugzilla@apache.org
https://bz.apache.org/bugzilla/show_bug.cgi?id=64755

Bingyu Shen <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |PatchAvailable

--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]