[Bug 64724] New: Enhance log message about dbdgroup_check_authorization

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[Bug 64724] New: Enhance log message about dbdgroup_check_authorization

Bugzilla from bugzilla@apache.org
https://bz.apache.org/bugzilla/show_bug.cgi?id=64724

            Bug ID: 64724
           Summary: Enhance log message about dbdgroup_check_authorization
           Product: Apache httpd-2
           Version: 2.5-HEAD
          Hardware: PC
                OS: Mac OS X 10.1
            Status: NEW
          Severity: normal
          Priority: P2
         Component: mod_authz_dbd
          Assignee: [hidden email]
          Reporter: [hidden email]
  Target Milestone: ---

Created attachment 37436
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=37436&action=edit
Enhance log message for dbdgroup_check_authorization function

Currently, dbdgroup_check_authorization() function will simply return
AUTHZ_DENIED for the group check authorization failures.
In default log level, the log message will only show general errors "client
denied by server configuration: xxxx".

It would be great to explicitly let the user know the group check fails in the
log message, just like what we did in authz_dbd_login() when login/logout
fails. It will not add much overhead since the authz failure happens rarely but
will take long time to troubleshoot.

I added log as follows (also filed a patch in the attachment.)

+    ap_log_rerror(APLOG_MARK, APLOG_ERR, 0, r, APLOGNO()
+                  "authz_dbd authorize: Authorization of user %s to access %s
failed, reason: "
+                  "user is not part of the 'require'ed dbd-group(s).",
+                  r->user, r->uri);

     return AUTHZ_DENIED;


Any feedbacks are appreciated!

--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[Bug 64724] Enhance log message about dbdgroup_check_authorization

Bugzilla from bugzilla@apache.org
https://bz.apache.org/bugzilla/show_bug.cgi?id=64724

Christophe JAILLET <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37436|0                           |1
           is patch|                            |

--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[Bug 64724] Enhance log message about dbdgroup_check_authorization

Bugzilla from bugzilla@apache.org
In reply to this post by Bugzilla from bugzilla@apache.org
https://bz.apache.org/bugzilla/show_bug.cgi?id=64724

Christophe JAILLET <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |PatchAvailable

--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]