[Bug 64591] New: Failing to build mod_lua with Lua 5.4

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[Bug 64591] New: Failing to build mod_lua with Lua 5.4

Bugzilla from bugzilla@apache.org
https://bz.apache.org/bugzilla/show_bug.cgi?id=64591

            Bug ID: 64591
           Summary: Failing to build mod_lua with Lua 5.4
           Product: Apache httpd-2
           Version: 2.4.43
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: mod_lua
          Assignee: [hidden email]
          Reporter: [hidden email]
  Target Milestone: ---

It's not possible to build mod_lua with Lua 5.4 installed, since they added 4th
argument to lua_resume function in Lua 5.4.

With Lua 5.4 installed, compilation fails:

mod_lua.c: In function 'lua_setup_filter_ctx':
mod_lua.h:51:28: error: too few arguments to function 'lua_resume'
   51 | #define lua_resume(a,b)    lua_resume(a, NULL, b)
      |                            ^~~~~~~~~~
mod_lua.c:413:18: note: in expansion of macro 'lua_resume'
  413 |             rc = lua_resume(L, 1);
      |                  ^~~~~~~~~~
In file included from mod_lua.h:44,
                 from mod_lua.c:18:
/usr/include/lua.h:300:15: note: declared here
  300 | LUA_API int  (lua_resume)     (lua_State *L, lua_State *from, int narg,
      |               ^~~~~~~~~~
In file included from mod_lua.c:18:
mod_lua.c: In function 'lua_output_filter_handle':
mod_lua.h:51:28: error: too few arguments to function 'lua_resume'
   51 | #define lua_resume(a,b)    lua_resume(a, NULL, b)
      |                            ^~~~~~~~~~
mod_lua.c:495:17: note: in expansion of macro 'lua_resume'
  495 |             if (lua_resume(L, 0) == LUA_YIELD) {
      |                 ^~~~~~~~~~
In file included from mod_lua.h:44,
                 from mod_lua.c:18:
/usr/include/lua.h:300:15: note: declared here
  300 | LUA_API int  (lua_resume)     (lua_State *L, lua_State *from, int narg,
      |               ^~~~~~~~~~
In file included from mod_lua.c:18:
mod_lua.h:51:28: error: too few arguments to function 'lua_resume'
   51 | #define lua_resume(a,b)    lua_resume(a, NULL, b)
      |                            ^~~~~~~~~~
mod_lua.c:527:17: note: in expansion of macro 'lua_resume'
  527 |             if (lua_resume(L, 0) == LUA_YIELD) {
      |                 ^~~~~~~~~~
In file included from mod_lua.h:44,
                 from mod_lua.c:18:
/usr/include/lua.h:300:15: note: declared here
  300 | LUA_API int  (lua_resume)     (lua_State *L, lua_State *from, int narg,
      |               ^~~~~~~~~~
In file included from mod_lua.c:18:
mod_lua.c: In function 'lua_input_filter_handle':
mod_lua.h:51:28: error: too few arguments to function 'lua_resume'
   51 | #define lua_resume(a,b)    lua_resume(a, NULL, b)
      |                            ^~~~~~~~~~
mod_lua.c:624:17: note: in expansion of macro 'lua_resume'
  624 |             if (lua_resume(L, 0) == LUA_YIELD) {
      |                 ^~~~~~~~~~
In file included from mod_lua.h:44,
                 from mod_lua.c:18:
/usr/include/lua.h:300:15: note: declared here
  300 | LUA_API int  (lua_resume)     (lua_State *L, lua_State *from, int narg,
      |               ^~~~~~~~~~
In file included from mod_lua.c:18:
mod_lua.h:51:28: error: too few arguments to function 'lua_resume'
   51 | #define lua_resume(a,b)    lua_resume(a, NULL, b)
      |                            ^~~~~~~~~~
mod_lua.c:646:17: note: in expansion of macro 'lua_resume'
  646 |             if (lua_resume(L, 0) == LUA_YIELD) {
      |                 ^~~~~~~~~~
In file included from mod_lua.h:44,
                 from mod_lua.c:18:
/usr/include/lua.h:300:15: note: declared here
  300 | LUA_API int  (lua_resume)     (lua_State *L, lua_State *from, int narg,
      |               ^~~~~~~~~~
make[4]: *** [/builddir/build/BUILD/httpd-2.4.43/build/rules.mk:212: mod_lua.s

--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[Bug 64591] Failing to build mod_lua with Lua 5.4

Bugzilla from bugzilla@apache.org
https://bz.apache.org/bugzilla/show_bug.cgi?id=64591

--- Comment #1 from Lubos Uhliarik <[hidden email]> ---
PR - https://github.com/apache/httpd/pull/133

--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[Bug 64591] Failing to build mod_lua with Lua 5.4

Bugzilla from bugzilla@apache.org
In reply to this post by Bugzilla from bugzilla@apache.org
https://bz.apache.org/bugzilla/show_bug.cgi?id=64591

Lubos Uhliarik <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |PatchAvailable

--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[Bug 64591] Failing to build mod_lua with Lua 5.4

Bugzilla from bugzilla@apache.org
In reply to this post by Bugzilla from bugzilla@apache.org
https://bz.apache.org/bugzilla/show_bug.cgi?id=64591

--- Comment #2 from Giovanni Bechis <[hidden email]> ---
Created attachment 37379
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=37379&action=edit
Lua54 diff

Different diff similar to the one that has been committed to haproxy
(https://github.com/haproxy/haproxy/commit/08ed98fd7963968de49593304fdd9234812845a4)
with config.m4 bits added.

--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]