[Bug 64413] New: Improve error message for dav_fs_open_stream

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[Bug 64413] New: Improve error message for dav_fs_open_stream

Bugzilla from bugzilla@apache.org
https://bz.apache.org/bugzilla/show_bug.cgi?id=64413

            Bug ID: 64413
           Summary: Improve error message for dav_fs_open_stream
           Product: Apache httpd-2
           Version: 2.5-HEAD
          Hardware: PC
                OS: All
            Status: NEW
          Severity: normal
          Priority: P2
         Component: mod_dav
          Assignee: [hidden email]
          Reporter: [hidden email]
  Target Milestone: ---

When dav fs want to PUT new contents, it first tries to open resource for
writing in dav_fs_open_stream(). It specifies two modes, DAV_MODE_WRITE_TRUNC,
DAV_MODE_WRITE_SEEKABLE, and default mode which simply open with OS default
permissions. However, the log for all three modes is the same. "An error
occurred while opening a resource."

This becomes misleading since it may fail for two reasons (1) In the default
mode to open with OS default permissions, the file may not exist (2) in the two
modes DAV_MODE_WRITE_XXXX , open for writing may fail because of file
permissions.

Also, it is appreciated to specify the actual file path to be opened, since
some Rewrite rules may be specified. The inconsistency between the real file
path and URL in the log may remind sysadmin about this. [1]

Therefore, I think we can improve the log a bit by providing the file name and
more detailed reasons for each failed case.

Any thoughts are appreciated!

[1]https://serverfault.com/questions/20169/webdav-on-centos-getting-403-error-when-attempt-to-upload

--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[Bug 64413] Improve error message for dav_fs_open_stream

Bugzilla from bugzilla@apache.org
https://bz.apache.org/bugzilla/show_bug.cgi?id=64413

Bingyu Shen <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #1 from Bingyu Shen <[hidden email]> ---
Created attachment 37219
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=37219&action=edit
A patch to improve the error message for dav_fs_open_stream

--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[Bug 64413] Improve error message for dav_fs_open_stream

Bugzilla from bugzilla@apache.org
In reply to this post by Bugzilla from bugzilla@apache.org
https://bz.apache.org/bugzilla/show_bug.cgi?id=64413

Joe Orton <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #2 from Joe Orton <[hidden email]> ---
Thanks for the patch!  Merged in r1881736.

--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]