[Bug 59660] New: mod_macro: Control on bad nesting

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 59660] New: mod_macro: Control on bad nesting

Bugzilla from bugzilla@apache.org
https://bz.apache.org/bugzilla/show_bug.cgi?id=59660

            Bug ID: 59660
           Summary: mod_macro: Control on bad nesting
           Product: Apache httpd-2
           Version: 2.5-HEAD
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Other Modules
          Assignee: [hidden email]
          Reporter: [hidden email]

mod_macro checks that nesting is complete inside a macro.
This looks a good default, however there are some cases where we want this and
it generates a warning for nothing.
Ex:
   <Macro MyBeginVhost @name @ip_port>
    <VirtualHost @ip_port>
     ServerName @name
     ...
   </Macro>

I'd like to add an option to suppress this warning when we need it.
The simplest option I see would be to add something on the macro definition
line itself. Because we may need some other options later, I guess a "flag"
would be the most generic approach.
What syntax would be the best one? maybe a (one character) /option after the
Macro keyword? Ex: "<Macro/n ...>" (and later "<Macro/ni ..." if we add another
flag)

--
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 59660] mod_macro: Control on bad nesting

Bugzilla from bugzilla@apache.org
https://bz.apache.org/bugzilla/show_bug.cgi?id=59660

--- Comment #1 from Marc Stern <[hidden email]> ---
Created attachment 34012
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=34012&action=edit
Add directives & flags to control warnings

MacroIgnoreEmptyArg: globally disable warning about empty arguments.
MacroIgnoreBadNesting: globally disable warning about bad nesting.

/IgnoreEmptyArg & /IgnoreBadNesting: disable warning in one macro definition

--
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 59660] mod_macro: Control on bad nesting

Bugzilla from bugzilla@apache.org
In reply to this post by Bugzilla from bugzilla@apache.org
https://bz.apache.org/bugzilla/show_bug.cgi?id=59660

--- Comment #2 from Jim Jagielski <[hidden email]> ---
Patch seems to use 'bool' ??

--
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 59660] mod_macro: Control on bad nesting

Bugzilla from bugzilla@apache.org
In reply to this post by Bugzilla from bugzilla@apache.org
https://bz.apache.org/bugzilla/show_bug.cgi?id=59660

Marc Stern <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #34012|0                           |1
        is obsolete|                            |

--- Comment #3 from Marc Stern <[hidden email]> ---
Created attachment 34326
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=34326&action=edit
Fixed the BOOL case

Add directives & flags to control warnings
Fixed the BOOL case

--
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 59660] mod_macro: Control on bad nesting

Bugzilla from bugzilla@apache.org
In reply to this post by Bugzilla from bugzilla@apache.org
https://bz.apache.org/bugzilla/show_bug.cgi?id=59660

Marc Stern <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #34326|0                           |1
        is obsolete|                            |

--- Comment #4 from Marc Stern <[hidden email]> ---
Created attachment 34365
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=34365&action=edit
Final version compiling on Windows/Linux

--
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 59660] mod_macro: Control on bad nesting

Bugzilla from bugzilla@apache.org
In reply to this post by Bugzilla from bugzilla@apache.org
https://bz.apache.org/bugzilla/show_bug.cgi?id=59660

--- Comment #5 from fooquency <[hidden email]> ---
We too would find it very useful to have a directive to hide the empty-argument
warning.

For instance, to have an argument for a base URL, sometimes this needs to be a
intentionally empty string ("") in the case of a top-level domain installation.

Seeing the warning every time an Apache restart is done is irritating and only
obscures real problems.

--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 59660] mod_macro: Control on bad nesting

Bugzilla from bugzilla@apache.org
In reply to this post by Bugzilla from bugzilla@apache.org
https://bz.apache.org/bugzilla/show_bug.cgi?id=59660

Marc Stern <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #6 from Marc Stern <[hidden email]> ---
Fixed in 1770843

--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Loading...